Add Rust implementation for Python client's update_run() method.
#1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
commented
Dec 9, 2024
| @@ -47,8 +47,7 @@ impl BlockingTracingClient { | |||
| Ok(Self { client: Arc::from(client) }) | |||
| } | |||
|
|
|||
| // N.B.: We use `Py<Self>` so that we don't hold the GIL while running this method. | |||
There was a problem hiding this comment.
The GIL info here was outdated, so I removed it. The current implementation drops the GIL explicitly by calling allow_threads().
| } | ||
|
|
||
| Ok(Some(attachments)) | ||
| } |
There was a problem hiding this comment.
I just moved this function down, to keep all the type definitions next to each other in the file. Otherwise it remained unchanged.
| @@ -196,6 +213,45 @@ impl FromPyObject<'_> for RunCommon { | |||
| } | |||
| } | |||
|
|
|||
| fn extract_attachments(value: &Bound<'_, PyAny>) -> PyResult<Option<Vec<Attachment>>> { | |||
There was a problem hiding this comment.
This function is unchanged, just moved farther down in the same file.
agola11
reviewed
Dec 9, 2024
Comment on lines
+245
to
+246
| ref_name: key.to_string(), | ||
| filename: key.to_string(), |
There was a problem hiding this comment.
The attachments dict is name -> (mime_type, data), so is using the key for both ref_name and filename the right thing to do?
agola11
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
update_run()client method in the Rust PyO3 bindings, and call it from the Python client if the Rust bindings are enabled.